fix: raise exception when response has an error #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vortexasdk/client.py
Outdated
|
|
||
| total = self._calculate_total(probe_response) | ||
|
|
||
| print(probe_response) |
Contributor
There was a problem hiding this comment.
Are you sure about this print here? For large responses, it could add significant performance overhead and make the logs unreadable. What if you log just the total number of records instead, response time and so? I think that info is more usable in most of the cases
Contributor
Author
There was a problem hiding this comment.
ah, that's actually leftover from debugging, I'll remove it
cojdev
added
echoes/intent: tech-debt
echoes/effort: XS
migueluzcategui
approved these changes
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELATED TICKETS
CHANGELOG
search_baserequest, an exception is now raised with that error.TESTS
COMMENTS